Conversation
This allows FW_PORT_SERIALIZATION to be set to 0.
LeStarch
left a comment
There was a problem hiding this comment.
The concern here is that we are adding a flag specifically to disable hubs, where there is no guarantee that these hubs are the only serial types used in the system. Done this way, it would result in a lot of feature flags.
A possible other solution would be to mark the GenericHub EXCLUDE_FROM_ALL. This would prevent it from building unless it is in the dependency graph of the build. In this case it would be a legitimate error.
This is how we updated the sub-topologies that added restrict_platforms. See:
|
|
|
@celskeggs did this work? If so, I'd like to get this PR updated, or closed. |
|
See #4178. This is the recommended fix. If this does not work, reopen this PR. |
|
Thanks, looks good, sorry for the slowness on our end. |
Change Description
Add FPRIME_ENABLE_SERIAL_HUBS cmake option to disable compilation of Svc/GenericHub.
Rationale
This allows FW_PORT_SERIALIZATION to be set to 0.
Testing/Review Recommendations
N/A
Future Work
N/A
AI Usage (see policy)
Not used.