Skip to content

Support disabling Svc/GenericHub#4035

Closed
celskeggs wants to merge 1 commit intonasa:develfrom
celskeggs:patch-23
Closed

Support disabling Svc/GenericHub#4035
celskeggs wants to merge 1 commit intonasa:develfrom
celskeggs:patch-23

Conversation

@celskeggs
Copy link
Collaborator

Related Issue(s) n/a
Has Unit Tests (y/n) n
Documentation Included (y/n) n
Generative AI was used in this contribution (y/n) n

Change Description

Add FPRIME_ENABLE_SERIAL_HUBS cmake option to disable compilation of Svc/GenericHub.

Rationale

This allows FW_PORT_SERIALIZATION to be set to 0.

Testing/Review Recommendations

N/A

Future Work

N/A

AI Usage (see policy)

Not used.

This allows FW_PORT_SERIALIZATION to be set to 0.
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concern here is that we are adding a flag specifically to disable hubs, where there is no guarantee that these hubs are the only serial types used in the system. Done this way, it would result in a lot of feature flags.

A possible other solution would be to mark the GenericHub EXCLUDE_FROM_ALL. This would prevent it from building unless it is in the dependency graph of the build. In this case it would be a legitimate error.

This is how we updated the sub-topologies that added restrict_platforms. See:

.

@celskeggs
Copy link
Collaborator Author

EXCLUDE_FROM_ALL should work. I'll give it a try.

@LeStarch
Copy link
Collaborator

@celskeggs did this work? If so, I'd like to get this PR updated, or closed.

@LeStarch
Copy link
Collaborator

See #4178. This is the recommended fix. If this does not work, reopen this PR.

@LeStarch LeStarch closed this Sep 22, 2025
@celskeggs
Copy link
Collaborator Author

Thanks, looks good, sorry for the slowness on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants