Conversation
|
This pull request introduces 4 alerts when merging f33933f into 83e2d45 - view on LGTM.com new alerts:
|
LeStarch
requested changes
Feb 8, 2022
Collaborator
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
Many of the returns that were removed were necessary for the code to function. In all cases where a return is on an error branch they need to be restored.
|
This pull request introduces 1 alert when merging 063ca59 into 72bc851 - view on LGTM.com new alerts:
|
LeStarch
requested changes
Feb 14, 2022
Collaborator
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
Two more missing returns. Other than that, it looks good!
Contributor
Author
I think it's fine now, Thank you. |
LeStarch
approved these changes
Feb 15, 2022
LeStarch
pushed a commit
that referenced
this pull request
Jun 29, 2022
* lint JSONDictionaryGen.py * lint implgen.py * clean if elif statements * lint AddSysPath * Update JSONDictionaryGen.py * Update gds_dictgen.py * Update tlm_packet_gen.py * Update pymod_dictgen.py * Update gds_dictgen.py * Update implgen.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Check and lint codes via pylint to find out what's missing or wrong and clean the code.
Rationale
Fixed bugs.
Testing/Review Recommendations
Built with
cmake ../ -DCMAKE_BUILD_TYPE=TESTINGandmake check.Future Work
Nothing for now.