Type mismatch in initializeHIRR

[j-huff]

At ipnfw.c:195, Sdr_list_insert_last is called with routingObj->viaPassageways as the sdr list Object. This is actually a sm list created with sm_list_create just a few lines above this in initializeHIRR. This should be revised such that either viaPassageways is an SDR list, or the appropriate sm list function is called instead of Sdr_list_insert_last.

[250MHz]

@iondev33 We could do a quick hack like

-			if (sdr_list_insert_last(sdr,
+			if (sm_list_insert_last(ionwm,
					routingObj->viaPassageways,
-					member->fqnn) == 0)
+					(PsmAddress) member->fqnn) == 0)

(Casting the FQNN to a PsmAddress is also done here

ION-DTN/bpv7/cgr/libcgr.c

Lines 2249 to 2251 in 4336f63

	if (sm_list_insert_last(ionwm,
	routingObj->proximateNodes,
	(PsmAddress) (contact->toFqnn)) == 0)

which I don't think is safe for 32-bit systems since you're casting unsigned long long to unsigned long.)

But note that:

1. IONe fixed this in their IRF code https://sourceforge.net/p/ione/code/ci/stable/tree/bpv7/irf/libirf.c#l32
2. You guys said that you wanted to remove region / HIRR related code and leave the IRF code in a separate branch until there's more testing. Since there doesn't seem to really be anything using HIRR and viaPassageways (and I don't think tryHIRR() really does anything), it might be better if we just remove initializeHIRR(), tryHIRR(), and viaPassageways from CgrRtgObject to resolve this issue

[dcpagotto]

fix in #67 — changed to sm_list_insert_last(ionwm, ...) which matches how the list is created and destroyed in libcgr.c