Skip to content

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Nov 7, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@github-actions github-actions bot added the enhancement New feature or request label Nov 7, 2024
@raisadz raisadz marked this pull request as ready for review November 7, 2024 11:50
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raisadz ! I left a comment regarding pandas, which may be doable to guarantee the order to be preserved

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @raisadz (and @FBruzzesi for reviewing)!

@MarcoGorelli MarcoGorelli merged commit e16b032 into narwhals-dev:main Nov 7, 2024
22 checks passed
MarcoGorelli pushed a commit to MarcoGorelli/narwhals that referenced this pull request Nov 7, 2024
@raisadz raisadz deleted the add-maintain-order branch November 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enh: add maintain_order to Expr.unique and Series.unique
3 participants