-
-
Notifications
You must be signed in to change notification settings - Fork 48
Make sure --filedeployment is counted as a valid operation #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure --filedeployment is counted as a valid operation #317
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice catch.
@WilliamBZA just a quick note for future PRs: there no need to link to the changed code lines as this is already part of the PR and can be visually checked quite easily. Unless, of course, you really want to highlight a particular change that may go unnoticed or that required special explanation/reasoning. 😉 |
@WilliamBZA thank you again for your contribution! 🙏😄 .NET nanoFramework is all about community involvement, and no contribution is too small. Please edit it and add an entry with your GitHub username in the appropriate location (names are sorted alphabetically):
(Feel free to adjust your name if it's not correct) |
Description
--filedeployment
operation does not result inNo operation was performed with the options supplied.
being output.Motivation and Context
--filedeployment
as the sole argument still results inNo operation was performed with the options supplied.
Home#1603How Has This Been Tested?
Screenshots
Types of changes
Checklist: