Skip to content

feat: testing] Test PooledEmbedding.mean_pooling - #252

Merged
n24q02m merged 2 commits into
mainfrom
test-mean-pooling-7521944429730682362
Mar 18, 2026
Merged

feat: testing] Test PooledEmbedding.mean_pooling#252
n24q02m merged 2 commits into
mainfrom
test-mean-pooling-7521944429730682362

Conversation

@n24q02m

@n24q02m n24q02m commented Mar 15, 2026

Copy link
Copy Markdown
Owner

🎯 What: The class method mean_pooling in PooledEmbedding lacked unit tests. This method wraps mathematical functionality mapping unmasked tokens arrays to mean pooled representations.

📊 Coverage:

  • Happy path: Tests standard batch processing of a typical 3D numpy array representing sequential data with varying attention_mask values.
  • Empty mask: Tests passing an all-zero attention_mask, verifying the division-by-zero avoidance strategy.
  • Varying lengths: Tests a batch where sequence tokens valid/unmasked lengths vary to verify calculations happen accurately.

Result: Test coverage for PooledEmbedding is vastly improved and mathematical accuracy of mean_pooling in edge cases is safely protected against future regressions.


PR created automatically by Jules for task 7521944429730682362 started by @n24q02m

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot changed the title 🧪 [testing] Test PooledEmbedding.mean_pooling feat: testing] Test PooledEmbedding.mean_pooling Mar 15, 2026
Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@n24q02m
n24q02m merged commit 7db4d0a into main Mar 18, 2026
16 checks passed
@n24q02m
n24q02m deleted the test-mean-pooling-7521944429730682362 branch March 18, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant