Skip to content

feat: test: add coverage for add_extra_session_options - #187

Merged
n24q02m merged 2 commits into
mainfrom
feat/test-add-extra-session-options-17211056917102681007
Mar 11, 2026
Merged

feat: test: add coverage for add_extra_session_options#187
n24q02m merged 2 commits into
mainfrom
feat/test-add-extra-session-options-17211056917102681007

Conversation

@n24q02m

@n24q02m n24q02m commented Mar 11, 2026

Copy link
Copy Markdown
Owner

🎯 What:
Added unit tests for add_extra_session_options in qwen3_embed/common/onnx_model.py which was missing test coverage.

📊 Coverage:

  • Tested valid paths (mutating enable_cpu_mem_arena to True and False).
  • Tested error paths (raising ValueError when an invalid option is provided).

Result:
Improved test coverage and safety for the OnnxModel option configuration logic.


PR created automatically by Jules for task 17211056917102681007 started by @n24q02m

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot changed the title 🧪 test: add coverage for add_extra_session_options feat: test: add coverage for add_extra_session_options Mar 11, 2026
Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@n24q02m
n24q02m merged commit d3e998c into main Mar 11, 2026
12 checks passed
@n24q02m
n24q02m deleted the feat/test-add-extra-session-options-17211056917102681007 branch March 20, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant