feat: 🎨 palette: fix password toggle state synchronization bug - #1022
feat: 🎨 palette: fix password toggle state synchronization bug#1022n24q02m wants to merge 1 commit into
Conversation
Replaced the brittle `dataset.toggling` logic in `_PASSWORD_TOGGLE_JS` with a robust text-content check (`b.textContent === "HIDE"`) to correctly distinguish between a user actively unmasking a password and external DOM attribute changes (like inputs becoming disabled). This ensures the SHOW/HIDE button maintains the correct state and accessibility labels even when the underlying form is manipulated or submitted. Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
1 participant
💡 What: Fixed a bug where the password SHOW/HIDE toggle button would disappear if the input field became disabled after the user clicked "SHOW".
🎯 Why: A brittle
dataset.togglingflag was being used. When the form disables inputs during submission, theMutationObserverwould hide the toggle button if the field was currently type "text", breaking the UI state.📸 Before/After: Visual behavior is unchanged in standard state, but the HIDE button now remains visible during async loading/disabled states.
♿ Accessibility: The fix ensures the button and its
aria-pressed/aria-labelstates stay correctly synchronized rather than disappearing entirely.PR created automatically by Jules for task 2138182330001607316 started by @n24q02m