Skip to content

feat(iroh)!: expose DynProtocolHandler #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

Frando
Copy link
Member

@Frando Frando commented Jun 26, 2025

Description

This makes DynProtocolHandler public to make building custom routers easier.

Breaking Changes

  • iroh::protocol::RouterBuilder::accept now takes impl Into<Box<dyn DynProtocolHandler>> instead of impl ProtocolHandler. Because of a blanket From impl this change does not need any changes by users: you can still pass any impl ProtocolHandler to accept. Additionally, if you have your own builder struct upstream, you can now also pass a Box<dyn DynProtocolHandler> to accept, which wasn't possible previously.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3366/docs/iroh/

Last updated: 2025-06-26T11:43:24Z

@Frando Frando changed the title feat: expose DynProtocolHandler feat(iroh): expose DynProtocolHandler Jun 26, 2025
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 54ae027

@Frando Frando changed the title feat(iroh): expose DynProtocolHandler feat(iroh)!: expose DynProtocolHandler Jun 26, 2025
@n0bot n0bot bot added this to iroh Jun 26, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Jun 26, 2025
@ramfox ramfox added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 056df1d Jun 26, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants