Skip to content

Conversation

@rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Nov 13, 2024

Description

...lazily created so it doesn't cost much if you don't use it

Breaking Changes

  • handle_rpc_request takes self, not &self

Notes & open questions

The RpcHandler stuff should be in quic-rpc maybe, or at least somehow DRYed.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

lazily created so it doesn't cost much if you don't use it
@github-actions
Copy link

github-actions bot commented Nov 13, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/7/docs/iroh_gossip/

Last updated: 2024-11-14T17:03:15Z

@rklaehn rklaehn marked this pull request as ready for review November 14, 2024 17:02
@rklaehn rklaehn merged commit 0eba891 into main Nov 15, 2024
26 checks passed
@rklaehn rklaehn deleted the mem-client branch November 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants