refactor: Remove gc tests #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they live in blobs now
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-docs/pr/12/docs/iroh_docs/ Last updated: 2024-11-29T16:18:33Z |
| @@ -83,7 +83,7 @@ parking_lot = "0.12.3" | |||
| testresult = "0.4.1" | |||
| nested_enum_utils = "0.1.0" | |||
| iroh-io = "0.6.1" | |||
| testdir = "0.9.1" | |||
| testdir = "0.7" | |||
There was a problem hiding this comment.
Just a wild shot in the dark to get the MSRV test to pass.
Got this in the MSRV test
error: package `cargo-platform v0.1.9` cannot be built because it requires rustc 1.78 or newer, while the currently active rustc version is 1.76.0
Either upgrade to rustc 1.78 or newer, or use
cargo update [email protected] --precise ver
where `ver` is the latest version of `cargo-platform` supporting rustc 1.76.0
and testdir seems to be the culprit
❯ cargo tree -i cargo-platform
cargo-platform v0.1.9
└── cargo_metadata v0.14.2
└── testdir v0.9.1
[dev-dependencies]
└── iroh-docs v0.28.0 (/Users/rklaehn/projects_git/iroh-docs)
So I would have to do some kind of bisect to find out when testdir started using a version of cargo-platform that requires rustc 1.78. Instead I just chose a random number.
There was a problem hiding this comment.
Why are we checking MSRV on dev-dependencies?
dignifiedquire
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They live in blobs now, where they belong. See n0-computer/iroh-blobs#23
Breaking Changes
None, just tests