Prevent race condition in TypeHandlerRegistry #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harawata
reviewed
Jan 22, 2020
| typeHandlerMap.put(javaType, map); | ||
| } else { | ||
| map.put(jdbcType, handler); | ||
| } |
There was a problem hiding this comment.
Wow...did this actually happen on production?
Regarding the change, how about updating typeHandlerMap at the end?
i.e.
Map<JdbcType, TypeHandler<?>> map = typeHandlerMap.get(javaType);
if (map == null || map == NULL_TYPE_HANDLER_MAP) {
map = new HashMap<>();
}
map.put(jdbcType, handler);
typeHandlerMap.put(javaType, map);There was a problem hiding this comment.
Yep, this happening a couple times in a week on startup. But our apps work like as "lamba" (many cold startups in a loop).
I agree, this will save a couple of code lines 👍
There was a problem hiding this comment.
I see. That explains it.
The fix is merged and should be available in the latest 3.5.4-SNAPSHOT.
Please let me know if you noticed anything.
Thank you for the PR, @PVlyubinskiy !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.