Skip to content

Status command indicates missing scripts #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

bradsokol
Copy link

Add some text in the status command's description field to indicate if a script file is not found in the file system. This can happen, for example, when running status on a database when the local environment is on a branch that does not include one of the migrations previously applied to the database from a different branch.

Brad Sokol added 4 commits September 3, 2015 13:18
Add some text in the status description field to indicate if a script file is
not found in the file system. This can happen, for example, when running
status on a database when the local environment is on a branch that does not
include one of the migrations previously applied to the database.
@harawata
Copy link
Member

Hi @bradsokol ,

Thank you for your contribution!
A few comments:

  • Test case for this should be in MigratorTest instead of RuntimeMigrationTest.
    There are some test cases comparing the output you can copy and modify.
  • And let's remove the StatusOperation#getMissingScriptCount() for now as it is there only for testing purpose, it seems.
    (I'm a little bit being nervous about adding a public method because once it is used in an external tool like maven plugin, it is difficult to make change in migration.)

@bradsokol
Copy link
Author

I no longer have the ability to develop or test this change. I'm going to close it so that it doesn't clutter the repo.

@bradsokol bradsokol closed this Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants