Driver Class Load Failure on 3.3.8

[kenny-qiao]

Background

Upgrade migration version from 3.3.7 to 3.3.8, then error happened like:

------------------------------------------------------------------------
-- MyBatis Migrations - up
------------------------------------------------------------------------
------------------------------------------------------------------------
-- MyBatis Migrations FAILURE
-- Total time: 0s
-- Finished at: Wed Nov 25 19:08:37 CST 2020
-- Final Memory: 7M/479M
------------------------------------------------------------------------

ERROR: Error creating ScriptRunner.  Cause: java.lang.ClassNotFoundException: org.mariadb.jdbc.Driver

JDBC connection properties:

I have no customized configurations, just init and up.

FYI: 3.3.7 works very well.

Do you have any idea about it? 🙏

[harawata]

Thank you for the report, @kenny-qiao !
I'll look into it as soon as I get some spare time.

[kenny-qiao]

@harawata I did some test and found the error came from Class.forName(driver); at

public JdbcConnectionProvider(String driver, String url, String username, String password) throws Exception {
  super();
  this.url = url;
  this.username = username;
  this.password = password;
  Class.forName(driver);
}

[h3adache]

Hi @kenny-qiao thanks for the report!
I can confirm the issue. It looks like it happened when we removed UnpooledDataSource.

[kenny-qiao]

@h3adache Ah, it is good.
So is there any plan for it, like issue a bug and fix it in next version? 🤔

[h3adache]

Yes we will prioritize a fix and release soon as we can!

[harawata]

Hi @kenny-qiao ,

@h3adache has already fixed the bug I carefully implemented. ☹️
Could you verify the fix using the latest snapshot?
There is a zip archive in the snapshot repo (please use the newest one if there are many).

[kenny-qiao]

@harawata @h3adache Thanks for your quickly fix.

I did a simple test and got error:

I think the big issue above has been fixed. But it seems that there is still a problem caused by using JdbcConnectionProvider instead of DataSourceConnectionProvider. 😢

Maybe you can re-open this issue. 🙏

FYI: I am keeping debugging the latest snapshot code. And I will update my progress here if there is.

[h3adache]

@kenny-qiao I'm sorry this is my fault.
It was late and I made a mistake refactoring my patch.

[kenny-qiao]

@harawata @h3adache
I have tested both mybatis-migrations-3.3.9-20201127.164611-2-bundle.zip and branch master.
They all work very well. 🚀

Thank you guys very much. 👍