Support user own tmate server #93
Conversation
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
I assume you tested this?
Also, since this is relevant only when starting the session, we could potentially pass the custom settings via the command-line, yes?
lib/index.js
Outdated
| await execShellCommand(`echo 'set +e' >/tmp/tmate.bashrc`); | ||
| const setDefaultCommand = `set-option -g default-command "bash --rcfile /tmp/tmate.bashrc" \\;`; | ||
|
|
||
| const tmateConfPath = external_path_default().join(external_os_default().homedir(), ".tmate.conf") |
There was a problem hiding this comment.
Why not use /tmp/tmate.conf?
There was a problem hiding this comment.
/tmp directory hasn't not a not UNIX-like OS (e.g. Windows). So I used ${HOME} dir.
But I found that this action uses MSYS2 and MSYS2 can uses /tmp.
I will change to use /tmp/tmate.conf.
There was a problem hiding this comment.
Also, since this is relevant only when starting the session, we could potentially pass the custom settings via the command-line, yes?
I see. I will change to add setDefaultCommand.
lib/index.js
Outdated
| const tmateConfPath = external_path_default().join(external_os_default().homedir(), ".tmate.conf") | ||
| if (core.getInput("tmate-server-host") !== "") { | ||
| core.debug("Configure your tmate server") | ||
| await execShellCommand(`echo 'set -g tmate-server-host ${core.getInput("tmate-server-host")}' >> ${tmateConfPath}`) |
There was a problem hiding this comment.
If you want to use $HOME/.tmate.conf, you'll have to quote the path.
Co-authored-by: Johannes Schindelin <[email protected]>
|
@dscho I fixed. Please review again! |
Co-authored-by: Max Schmitt <[email protected]>
3 participants
Hi, I found this action works very well! Thank you for creating this! 😊
Now,
action-tmateonly supports usingssh.tmate.io.This change adds inputs about using other tmate servers.
I referred "Host your own tmate servers" in https://tmate.io/.