Fix for VS2019 #68
Merged
Fix for VS2019 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a GitHub workflow that can be triggered manually, executing the GitHub Action in a multitude of scenarios. Signed-off-by: Johannes Schindelin <[email protected]>
The `tmate` we use on Windows is compiled using MSYS2, which has a very specific idea where `/tmp/` is: it internally translates Unix-style absolute paths into absolute Windows paths, and that is different from what node.js does: `/tmp/` translates to `C:/tmp/`, while MSYS2 interprets `/tmp/` as `C:/msys64/tmp/`. Let's execute a shell command to write the temporary `bashrc` file so that it lands in the location expected by our `tmate` invocation. This fixes mxschmitt#67 Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D'oh! In my recent workaround, I totally forgot that on Windows,
/tmpis not equal to/tmp...This fixes that, and it also adds a (manual) workflow that can be used for interactive testing.
This fixes #67