Fix regex to match Almalinux correctly #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AlmaLinux, the ID in /etc/os-release is quoted ``` $ docker run -it --rm almalinux:9 cat /etc/os-release | grep ^ID= 2>/dev/null ID="almalinux" ```
dscho
approved these changes
Oct 23, 2025
| try { | ||
| const osRelease = await fs.promises.readFile("/etc/os-release") | ||
| const match = osRelease.toString().match(/^ID=(.*)$/m) | ||
| const match = osRelease.toString().match(/^ID="?(.*?)"?$/m) |
Collaborator
There was a problem hiding this comment.
It would probably be slightly more robust to do this instead:
- return match ? match[1] : "(unknown)"
+ return match ? match[1].replace(/^"(.*)"$/, "$1") : "(unknown)"But this is good enough, I think, there is little chance that /etc/os-release contains an unmatched quote at the start or end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AlmaLinux, the ID in /etc/os-release is quoted