ci: verify that the action.yml files are in sync
#223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
verify-detached/action.yml-in-pr-builds
branch
from
5d64a08 to
88b2bac
Compare
In #218, I added a convenient way to launch this Action in detached mode: `mxschmitt/action-tmate/detached@v3`. The way this is implemented is a copy/edited version of `action.yml` in the `detached/` subdirectory. This runs the danger of inadvertent divergences, as happened in #221 (which I caught in time and the contributor gracefully addressed). Let's add automation not only to update the file easily but also to cause a failure in the PR build with a helpful message suggesting how to fix the problem. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
verify-detached/action.yml-in-pr-builds
branch
from
5c676f0 to
10acb04
Compare
There was a difference in whitespace, caught by the new step in `checkin.yml`. Signed-off-by: Johannes Schindelin <[email protected]>
The output of that step, if something goes wrong, claims that `dist/` is not up to date, but the build product is in `lib/`. Also, `git status -s` shows not only differences in the tracked files, but also untracked files (which should not exist at that stage). Let's avoid puzzling contributors when there are untracked files by logging the output of `git status -s`. Signed-off-by: Johannes Schindelin <[email protected]>
mxschmitt
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #218, I added a convenient way to launch this Action in detached mode:
mxschmitt/action-tmate/detached@v3.The way this is implemented is a copy/edited version of
action.ymlin thedetached/subdirectory.This runs the danger of inadvertent divergences, as happened in #221 (which I caught in time and the contributor gracefully addressed).
Let's add automation not only to update the file easily but also to cause a failure in the PR build with a helpful message suggesting how to fix the problem.