workflows: update action deps and runners #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
dscho
reviewed
Jan 9, 2023
Collaborator
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
- update actions to latest
- update to use latest LTS nodejs for the PR test
- add macos-12.0 and windows-2022
- remove deprecated runners, macos-10.15 and ubuntu-18.04
In general, I prefer such separated concerns to be implemented in separate commits, not least because it makes it much easier to review the changes (and avoid slipping in inadvertent changes).
I'll defer to @mxschmitt whether we want to split this large commit into four small ones or not.
Owner
|
These are all non user-facing changes, so lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.