Skip to content

Conversation

@iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Oct 9, 2022

Fix #135

Note : I would like you to merge #137 first, so I can modify the container test matrix in this PR

@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 13, 2022

Rebased on master & tested !

Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just have two suggestions how to improve this PR, @iTrooz please let me know whether you agree or not.

@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 17, 2022

Done ! Is this what you had in mind ?

Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@mxschmitt mxschmitt merged commit ac30c9d into mxschmitt:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default behaviour of sudo

3 participants