Fix crash on move instrument above system marking #29115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fixCrashOnMoveInstrumentAboveSystemMarking
branch
from
2257e87 to
c91ea14
Compare
its-not-nice
approved these changes
Aug 7, 2025
mike-spa
force-pushed
the
fixCrashOnMoveInstrumentAboveSystemMarking
branch
from
c91ea14 to
1ebfa42
Compare
instead of an individual stave property
reloaded because all rows may have shifted index
mike-spa
force-pushed
the
fixCrashOnMoveInstrumentAboveSystemMarking
branch
from
1ebfa42 to
c836e5d
Compare
RomanPudashkin
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29045
This PR should fix all the weird combination of cases one can get when moving not just the bottom system object layer but also the instruments around the bottom layer.
There is also some refactoring, namely the method
Score::isSystemObjectStaff(Staff*)has becomeStaff::isSystemObjectsStaff(), which is simpler and more idiomatic. But most importantly, I've realized that it's not a good idea to model the "system objects below the bottom staff" option as the property of an individual staff, cause we'd need to constantly set/unset it as we move instruments at the bottom even though we're not touching the bottom SO layer. It's better to model the option as a property of the score itself, i.e. as a style.