Skip to content

19571 empty lines in text frames #29018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Thomas-Ganter
Copy link
Contributor

Resolves: #19571

Empty lines were ignored when applying format changes.
This change now makes sure that empty lines now will be included in updates.
This resolves the odd behavior of scaling text boxes that contain empty lines.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

- Created initial test case for Issue 19571
- Updated test case with improved validation
@Thomas-Ganter
Copy link
Contributor Author

image

Type 30 in Size ...
image

Press "Size Up Arrow" 5 times ...
image

Tests still all work.
Feels like it can be merged.

@Thomas-Ganter Thomas-Ganter marked this pull request as ready for review July 31, 2025 11:16
@cbjeukendrup cbjeukendrup self-requested a review August 1, 2025 20:01
@Thomas-Ganter
Copy link
Contributor Author

@cbjeukendrup does there seem to be something missing or preventing the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty lines inside text in frames do not resize properly when changing font size
1 participant