Skip to content

👷 Enable testing on Python 3.14 - #219

Merged
denialhaag merged 2 commits into
mainfrom
314-testing
Aug 22, 2026
Merged

👷 Enable testing on Python 3.14#219
denialhaag merged 2 commits into
mainfrom
314-testing

Conversation

@denialhaag

@denialhaag denialhaag commented Oct 13, 2025

Copy link
Copy Markdown
Member

Description

This PR enables testing on Python 3.14.

Fixes #206

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Oct 13, 2025
@denialhaag denialhaag added continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file python Pull requests that update python code labels Oct 13, 2025
@coderabbitai

coderabbitai Bot commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updates to CI and packaging metadata: minor YAML formatting change in the CD workflow, Python 3.14 added to the nox test matrix, and conditional dependency constraints in pyproject.toml reordered and extended to explicitly cover Python 3.14.

Changes

Cohort / File(s) Summary of changes
CI workflow tweak
.github/workflows/cd.yml
Changed subject-path value in the Generate artifact attestation step from quoted "dist/*" to unquoted dist/*.
Test matrix update
noxfile.py
Appended "3.14" to PYTHON_ALL_VERSIONS enabling tests to run on Python 3.14.
Dependency constraints
pyproject.toml
Reordered and extended environment-marked dependency constraints (numpy, scipy, pandas) and added pydantic-core / symengine adjustments to explicitly cover Python 3.14. No public API/signature changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related issues

Poem

Hoppity hop, I nudge the build anew,
Three point one four joins the testing crew. 🐇
Constraints arranged in tidy line,
A YAML tweak — the artifacts align.
Carrots counted, CI hums light and true.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning Most changes are in scope for enabling Python 3.14, but there is a minor unrelated formatting tweak in .github/workflows/cd.yml (changing a quoted "dist/" to unquoted dist/) that is not required by the linked issue. Either remove the unrelated cd.yml formatting change or move it to a separate housekeeping PR, and document any non-obvious reasons why that workflow edit is included in this 3.14 testing change.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues Check ✅ Passed The changes implement the linked issue #206: the noxfile adds Python 3.14 to the test matrix and pyproject.toml includes dependency constraints and overrides to enable compatibility with Python 3.14, which satisfies the issue's proposed solution.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title check ✅ Passed The title clearly and concisely describes the primary change: enabling testing on Python 3.14.
Description check ✅ Passed The description summarizes the change, references issue #206, and includes a completed checklist; dependency details are not listed.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 314-testing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@denialhaag

denialhaag commented Oct 13, 2025

Copy link
Copy Markdown
Member Author

This PR has to wait until a new version of qiskit-aer is released (see Qiskit/qiskit-aer#2378).

@denialhaag
denialhaag marked this pull request as draft October 13, 2025 23:59

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pyproject.toml (1)

60-64: Add the Python 3.14 trove classifier.

You’re declaring 3.14 support elsewhere, but the classifiers still stop at 3.13. Please add Programming Language :: Python :: 3.14 so the published metadata reflects the new support level.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc13cfd and 8524097.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (3 hunks)

Comment thread pyproject.toml Outdated
@denialhaag
denialhaag force-pushed the 314-testing branch 2 times, most recently from db261ba to 125ff5d Compare August 21, 2026 18:42
Comment thread pyproject.toml Outdated
@denialhaag
denialhaag force-pushed the 314-testing branch 6 times, most recently from ed75873 to bb2bd83 Compare August 22, 2026 11:27
@denialhaag
denialhaag marked this pull request as ready for review August 22, 2026 11:53

@denialhaag denialhaag left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context:

Comment thread pyproject.toml
Comment thread pyproject.toml
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...olver/equivalence_checking/equivalence_checking.py 40.0% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@denialhaag
denialhaag requested a review from burgholzer August 22, 2026 12:39

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small comment.

Comment thread pyproject.toml Outdated
@denialhaag
denialhaag enabled auto-merge (squash) August 22, 2026 21:31
@denialhaag
denialhaag merged commit 29a8835 into main Aug 22, 2026
13 checks passed
@denialhaag
denialhaag deleted the 314-testing branch August 22, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

👷🏼🐍 Enable testing on Python 3.14

2 participants