add quic-v1 protocol #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhchia , to the best of my knowledge, the linter errors here are already in the master. Should i fix them in the PR or keep it as is? |
|
@justheuristic thanks for the update. I'd think this PR is complete and ready to merge and the lint fix can be in another PR. |
Closed
|
lint failure issue: #64. @justheuristic feel free to fix this one :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 1 month ago, the table was extended with quic-v1.
Several multiaddr users (notably, go-libp2p v0.24.0) now support this version of QUIC. This PR updates py-multiaddr so that it can also parse multiaddresses with quic-v1 . If possible, we'd really appreciate if this change finds its way to PyPI. We're using a pythonic interface to go-libp2p and the old QUIC already has an end-of-life date.
It passes all checks except lint. Lint errors appear unrelated to this PR.
https://app.travis-ci.com/github/multiformats/py-multiaddr/jobs/590656750