Add TLS as per GH/multiformats/multicodec#145 #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntninja
added a commit
to ntninja/py-multiaddr
that referenced
this pull request
Aug 24, 2020
This was referenced May 26, 2021
Stebalien
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
A bit late, but I see no real reason not to do this.
Concerns I've had before:
- Maybe we want it to take an argument?
- Are the semantics of HTTPs and /tls/http different?
In practice, I think the answer to both is "no". Unfortunately, authentication information will need to be inferred from the context given the... limitations of the multiaddr format.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a no-brainer to merge as it was already merged in the MultiCodec repo and the two are supposed to be in sync with regards to MultiAddr formats.