-
Notifications
You must be signed in to change notification settings - Fork 55
fix!: identity hash is Hasher<"identity", 0> #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix!: identity hash is Hasher<"identity", 0> #314
Conversation
@achingbrain any qualms against this one? |
Co-authored-by: Alex Potsides <[email protected]>
With hindsight E.g. // identity.ts
import type { SyncMultihashHasher } from './interface.js'
// ... other code
export const identity: SyncMultihashHasher<0x00> = { code, name, encode, digest } One problem is that One (breaking) solution would be remove the Alternatively (non-breaking) we can add the |
Breaking change because return type no longer supports sync (aligns with other hashers)
Fixes #313