fix: Add p2p protocol (alias for ipfs) #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
changed the title
jacobheun
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Other than fixing the commit messages to comply with https://github.com/ipfs/community/blob/master/js-code-guidelines.md#type, such as fix: add p2p protocol this looks good.
We should get this released to improve out of the box compatibility, so go and rust nodes can communicate with js over /p2p.
|
@jacobheun can you push this forward? We need the support in both go and js (and everywhere else, really) before we can make switch the default string format to |
ghost
assigned
Merged
|
Closing this in favor of #76. It just rebases this and fixes the latest tests from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68