Skip to content
This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Apr 8, 2019

Add 4th optional parameter introduced by #77

Add 4th optional parameter introduced by multiformats#77
@vmx
Copy link
Member

vmx commented Apr 8, 2019

If it's an external file, could things like that be checked somehow? Even without this patch running flow won't result in an error.

@vmx vmx merged commit 63cd5f3 into multiformats:master Apr 8, 2019
@Gozala
Copy link
Contributor Author

Gozala commented Apr 8, 2019

If it's an external file, could things like that be checked somehow? Even without this patch running flow won't result in an error.

Flow will ignore anything that doesn't start with // @flow in this case it's typedefs which were valid before and are still valid, that's why it will type check.

Only way to keep implementation to comply with type definition is to annotate implementation accordingly. That is to say you could have significant type definitions in separate file and only few comments in the source, but there will still need to be some comments in the source.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants