Conversation
|
Deploy preview: https://deploy-preview-21968--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
Merging this PR will degrade performance by 11.86%
Performance Changes
Comparing Footnotes |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Probably better to keep them separate now, we can merge later if it makes sense.
The current implementation just looks like a slightly different radar chart. What would make it differentiate from a |
To be precise, the radar is a subset of a radial line chart :)
This chart allow you to use any scale (like for the line charts). For example you could do the same charts with a data point per day, or with non evenly spaced data points By the way I just realize D3 has a shape for it https://d3js.org/d3-shape/radial-line
I think this implementation is more flexible than just the usecase |
🤔 guess i had to replace the point scale by a linear one...
But still, values are mapped to the middle of the segments, which is weird. I think the API is not clear. Shouldnt the rotation axis always be 0-360? |
I don't get this part. If axis are inexistent how can you map data and position? The idea of those charts is to build the same feature as the line chart but with x/y replaced by rotation/radius for specific type of dataset: https://observablehq.com/@observablehq/why-use-a-radial-data-visualization Your drawing make me think about the scatter series with linked points in a polar coordinate system
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
My idea was that the "angle axis" would always be static (0-360)
yeah it is similar. I think we can go with |
That would be an edge case. You can still do |




An attempt to build a polar line chart. For now it renders basic grid and lines
Point to discuss
Should we have a single line series types that can be used for polar and cartesian. Seems to work for the axes ids, because
[x|y|radius|rotation]AxisIdare all optional. It's just that the autocomplet will propose some proerty that make no sense. Technically in theLineChart/RadialLineChartcompoennt we can remove the useless one. In the composition settings, it might be a bit harder,The naming
RadialLineChart, because it's the one I've see the most, and Polar chart seemsPolarGridbyRadialGridandPolarDataProvideryRadialDataProvider. The Radar has it's ownRadarDataProvideso the name ofPolaris not yet exposed to the devsFollow up
Components
Features