Skip to content

[docs] Add most Progress TypeScript demos #15104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 31, 2019
Merged

[docs] Add most Progress TypeScript demos #15104

merged 7 commits into from
Mar 31, 2019

Conversation

sperry94
Copy link
Contributor

Adding TS demos for Progress components as a part of #14897

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 29, 2019 •
edited
Loading

No bundle size changes comparing 264c64d...4c43dc6

Generated by 🚫 dangerJS against 4c43dc6

@oliviertassinari oliviertassinari changed the title [docs] Adding Progress Typescript demos [docs] Add Progress Typescript demos Mar 29, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 29, 2019
@oliviertassinari oliviertassinari changed the title [docs] Add Progress Typescript demos [docs] Add Progress TypeScript demos Mar 30, 2019
oliviertassinari
oliviertassinari reviewed Mar 30, 2019
View reviewed changes
@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 30, 2019
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 30, 2019
@sperry94
Copy link
Contributor Author

@oliviertassinari Looking at the DelayingAppearance component, it looks like there might be an issue with the way the timer is being carried over between renders. Since timer is defined in the component, the timer will be reset to undefined on each render, which will prevent it from being cleared correctly when unmounting.

I am moving the changes to this component out for now so this can be addressed in another PR!

@oliviertassinari
Copy link
Member

@sperry94 Correct. It's better to handle the problem in a different pull request :)

eps1lon
eps1lon reviewed Mar 30, 2019
View reviewed changes
@eps1lon eps1lon changed the title [docs] Add Progress TypeScript demos [docs] Add most Progress TypeScript demos Mar 31, 2019
@eps1lon eps1lon mentioned this pull request Mar 31, 2019
Closed
@eps1lon eps1lon merged commit 37962a2 into mui:next Mar 31, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 31, 2019

@sperry94 Much appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sperry94 @mui-pr-bot @oliviertassinari @eps1lon