Skip to content

Conversation

@TimTheBig
Copy link
Contributor

@TimTheBig TimTheBig commented May 25, 2025

This patch makes geo-types and geojson optional so the user can reduce dependencies. They are still enabled by default to prevent breaking changes.

@mthh
Copy link
Owner

mthh commented May 26, 2025

Hi and thank you for your contribution!

It seems the tests are falling because of cargo fmt --all --check, can you run cargo fmt --all and push the changes?

@TimTheBig
Copy link
Contributor Author

TimTheBig commented May 27, 2025

can you run cargo fmt --all and push the changes?

For sure, done

@TimTheBig
Copy link
Contributor Author

I find that I have to use the geo integration do you think you could add some getters for the inner geometry of a SFCGALGeometry?

@mthh
Copy link
Owner

mthh commented May 27, 2025

For sure, done

Thanks!

I find that I have to use the geo integration do you think you could add some getters for the inner geometry of a SFCGALGeometry?

Why not? What do you have in mind?
SFCGeometry currently implements the ToCoordinates trait (in addition to the TryInto and ToGeoJSON/FromGeoJSON traits, which convert to/from geo-types and geojson, respectively), which provides a way of retrieving the coordinates of a geometry of the various types supported by SFCGAL (in the form of a CoordSeq).

@mthh
Copy link
Owner

mthh commented May 27, 2025

I'm merging this but let's continue the discussion about your last question, here or on a new issue.

@mthh mthh merged commit a34f711 into mthh:master May 27, 2025
3 checks passed
@TimTheBig
Copy link
Contributor Author

I'm merging

Great

let's continue the discussion about your last question, here or on a new issue.

Are the geometry types in sfcgal structs/classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants