streams: Rework stream merging to use ordered-read-streams #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streams: Rework stream tests to be more stream compliant
phated
commented
Oct 18, 2022
Comment on lines
+3
to
+4
| // @ts-expect-error | ||
| import * as ordered from 'ordered-read-streams'; |
There was a problem hiding this comment.
If this PR ends up being desirable to merge, I can work on getting some sort of .d.ts output for ordered-read-streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streams: Rework stream tests to be more stream compliant
What is the purpose of this pull request?
I'm investigating fast-glob for usage in gulp via glob-stream and I noticed that you were using merge2, which does some really unconventional things. This swaps the dependency for
ordered-read-streamswhich has recently been overhauled to be stream/streamx-compliant.What changes did you make? (Give an overview)
I swapped the merge2 dependency for ordered-read-streams and removed a lot of the event rebinding that was done for merge2. I then updated the tests to show better stream compliance—using things like
destroyand Readables that provide data instead of trying to propagate events and rely on specific listeners being bound.