-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
WebGPURenderer: Remove _forceViewport #31189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
I verified that with this change, all the surfaces are correctly sized and multisampled: |
Awesome! That is what I was hoping for! The PR fixes the calls of
With this PR, calls like below should be obsolete since the dimensions are now extracted from the output render target. But I suggest we do this with a second PR (maybe targeting three.js/src/renderers/common/XRManager.js Lines 1023 to 1024 in 2dba5a8
|
ok. Will you let me know when that is? |
You can see the dates for upcoming releases here: https://github.com/mrdoob/three.js/milestones (I'm a day late for the one this month. I'll probably be two days late...) |
This addresses review #31134 (comment)
@Mugen87 , does this diff implement what you were looking for in #31134 (comment)? Or there calls to
setSize
I can remove?