CSMShadowNode: Fix toggle of castShadow
.
#31186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31183
Description
It was not possible so far to toggle the
castShadow
property of directional lights usingCSMShadowNode
.AnalyticLightNode
callsdispose()
on shadow nodes that are not used anymore.CSMShadowNode
uses itsdispose()
method to remove additions to the scene graph to make cascading work. If the instance ofCSMShadowNode
is now used again (becausecastShadow
is set back totrue
), the state must be restored. The PR is doing this inupdateBefore()
.@sunag I have updated
ShadowBaseNode
by removing thedispose()
method. SettingupdateBeforeType
toNodeUpdateType.NONE
is an issue since when a shadow node is reused after a dispose,updateBefore()
is never executed anymore. BecauseupdateBefore()
is not called when lights don't cast shadows, it seems better to not changeupdateBeforeType
so shadow nodes don't have restore the update type on their own.