Skip to content

TSL: Fix object-as-parameter checking for Fn() #31176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented May 26, 2025

Fixes #31172

Description

Fix object-as-parameter checking for Fn().

@sunag sunag added this to the r177 milestone May 26, 2025
@sunag sunag marked this pull request as ready for review May 26, 2025 17:07
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 551.79
153.05
551.84
153.07
+50 B
+22 B
WebGPU Nodes 551.14
152.89
551.19
152.91
+50 B
+21 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.44
113.28
468.44
113.28
+0 B
+0 B
WebGPU 626.81
169.73
626.86
169.75
+50 B
+22 B
WebGPU Nodes 581.66
159.06
581.71
159.08
+50 B
+22 B

@sunag sunag merged commit c548fe9 into mrdoob:dev May 26, 2025
12 checks passed
@sunag sunag deleted the dev-fix-verification branch May 26, 2025 17:28
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map passed as first argument of a Fn ( [ map ] ) breaks
1 participant