TSL: Introduce namespace
#31168
Merged
TSL: Introduce namespace
#31168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This was referenced May 31, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* Nodes: use `.global` * introduce `namespace` * update description * use namespace to `material.positionNode` * add `docs`
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* Nodes: use `.global` * introduce `namespace` * update description * use namespace to `material.positionNode` * add `docs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30105
Description
Important for TSL functions that use
.once( namespace )to ensure that the namespace will run twice,once when the node is build in the specific namespace and once when the node is built in the others namespace.
This is useful for nodes like
positionWorldthat need to be re-updated if used inmaterial.positionNodeand outside of it in the same material.It was initially done here for
positionNode, but now the API can be used for other inputs like the one planned for the normals solution.