Skip to content

TSL: Improve build stages #31156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2025
Merged

TSL: Improve build stages #31156

merged 2 commits into from
May 24, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented May 24, 2025

Description

Fixed some nodes where the setup and analyze stages were ignored, which could cause problems in event calls among other optimization problems, most notably in post-processing nodes.

In addition to node revisions, a check was added to the node build that will force the build of the previous stage if it has not been done.

@sunag sunag added this to the r177 milestone May 24, 2025
Copy link

github-actions bot commented May 24, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 551.2
152.85
551.7
152.97
+500 B
+111 B
WebGPU Nodes 550.55
152.7
551.05
152.81
+500 B
+110 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.12
113.14
468.12
113.14
+0 B
+0 B
WebGPU 625.84
169.43
626.34
169.55
+500 B
+125 B
WebGPU Nodes 580.7
158.75
581.2
158.87
+500 B
+115 B

@sunag sunag marked this pull request as ready for review May 24, 2025 15:19
@sunag sunag merged commit 605fb3b into mrdoob:dev May 24, 2025
12 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* improve build stages

* cleanup
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* improve build stages

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant