Skip to content

Examples: Improve noise.png. #31137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Examples: Improve noise.png. #31137

merged 1 commit into from
May 20, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 20, 2025

Related issue: #31132

Description

The PR fixes examples/textures/noise.png by removing all transparent parts (a noise texture really should not be authored like that) and also the PNG headers mentioned in #31132 (comment) which lead to a different image loading in WebGL and WebGPU.

Since the image was added via #30695, it was necessary to update the E2E screenshot for webgl_uv_random.

@Mugen87 Mugen87 added this to the r177 milestone May 20, 2025
@Mugen87 Mugen87 merged commit ce77197 into mrdoob:dev May 20, 2025
11 checks passed
@mrdoob
Copy link
Owner

mrdoob commented May 20, 2025

/fyi @lo-th

RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants