Skip to content

NodeMaterial: Execute setupVertex() if vertexNode is defined #31136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented May 20, 2025

Fixes #31131

Description

Execute setupVertex() if vertexNode is defined which can be useful to reuse the vertex transformation by modifying the MVP.

@sunag sunag added this to the r177 milestone May 20, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 550.2
152.54
550.2
152.54
+4 B
+6 B
WebGPU Nodes 549.55
152.38
549.55
152.38
+4 B
+6 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.12
113.14
468.12
113.14
+0 B
+0 B
WebGPU 625.57
169.31
625.57
169.32
+4 B
+8 B
WebGPU Nodes 580.42
158.62
580.42
158.63
+4 B
+10 B

@sunag sunag marked this pull request as ready for review May 20, 2025 05:06
@sunag sunag merged commit af8709e into mrdoob:dev May 20, 2025
12 checks passed
@sunag sunag deleted the dev-fix-setupvertex branch May 20, 2025 05:06
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot override vertexNode of instanced mesh with morphTargets (TSL)
1 participant