NodeMaterial: Introduce .maskNode and improve shapeCircle()
#31127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
mrdoob
reviewed
May 20, 2025
Comment on lines
+141
to
+143
| material.opacityNode = shapeCircle(); | ||
| material.alphaToCoverage = true; | ||
| material.transparent = true; |
There was a problem hiding this comment.
Do we need alphaToCoverage when we are using opacityNode?
|
How's |
The circle that
|
This was referenced May 28, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…ob#31127) * always check `alphaTest` but optimize uniform to constant if necessary * Introduce `.maskNode` * improve `shapeCircle` * `webgpu_compute_particles`: use `shapeCirle()`
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…ob#31127) * always check `alphaTest` but optimize uniform to constant if necessary * Introduce `.maskNode` * improve `shapeCircle` * `webgpu_compute_particles`: use `shapeCirle()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31092
Description
Introduce
.maskNodeas was done in the old NodeMaterial, this simplifies the use ofalphaTestfor procedural purposes sincealphaTestNodeneeds to deal with the current opacity..maskNode.alphaTestbut optimize uniform to constant if necessaryshapeCircle()