Skip to content

Cleanup src/three.tsl.js #31109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Cleanup src/three.tsl.js #31109

merged 1 commit into from
May 14, 2025

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 14, 2025

Related issue: -

Description

These nodes aren't exported from src/nodes/TSL.js, so src/Three.TSL.js shouldn't (re)export them.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 549.59
152.34
549.59
152.34
+0 B
+0 B
WebGPU Nodes 548.94
152.19
548.94
152.19
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 467.34
112.95
467.34
112.95
+0 B
+0 B
WebGPU 624.5
169.06
624.5
169.06
+0 B
+0 B
WebGPU Nodes 579.35
158.35
579.35
158.35
+0 B
+0 B

@sunag sunag merged commit d51e356 into mrdoob:dev May 14, 2025
12 checks passed
@ycw ycw deleted the 1 branch May 14, 2025 22:16
@Mugen87 Mugen87 added this to the r177 milestone May 15, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants