Skip to content

ShadowMaskModel: Fix usage with non shadow casting light. #31081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2025
Merged

ShadowMaskModel: Fix usage with non shadow casting light. #31081

merged 3 commits into from
May 10, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 10, 2025

Fixed #31079.

Description

The PR makes sure ShadowMaskModel is compatible with lights which cast no shadows.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.29
78.32		 336.29
78.32		 +0 B
+0 B
WebGPU 548.41
152.04		 548.43
152.04		 +21 B
+4 B
WebGPU Nodes 547.76
151.88		 547.78
151.89		 +21 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 466.23
112.58		 466.23
112.58		 +0 B
+0 B
WebGPU 623.19
168.74		 623.21
168.74		 +21 B
+3 B
WebGPU Nodes 578.06
158.03		 578.06
158.03		 +0 B
+0 B

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 10, 2025 •
edited
Loading

I have migrated one of the physics demos to WebGPURenderer so we have at least one example that uses ShadowMaterial with WebGPU.

@Mugen87 Mugen87 added this to the r177 milestone May 10, 2025
@Mugen87 Mugen87 merged commit b9ba3b4 into mrdoob:dev May 10, 2025
12 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@Mugen87 @RuthySheffi
ShadowMaskModel: Fix usage with non shadow casting light. (mrdoob#31081)
25b7ff9 
* ShadowMaskModel: Fix usage with non shadow casting light.

* Examples: Move Jolt demo to WebGPU.

* E2E: Update screenshot.
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@Mugen87 @RuthySheffi
ShadowMaskModel: Fix usage with non shadow casting light. (mrdoob#31081)
8a60960 
* ShadowMaskModel: Fix usage with non shadow casting light.

* Examples: Move Jolt demo to WebGPU.

* E2E: Update screenshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r177
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'getNodeType')
1 participant
@Mugen87