MaterialNode: Fix dashOffset
with LineDashedMaterial.
#31008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31006.
Description
LineDashedNodeMaterial
is the node variant ofLineDashedMaterial
. The node version supports a propertydashOffset
which does exist forLineDashedMaterial
. To make the TSL material propertymaterialLineDashOffset
compatible withLineDashedMaterial
,MaterialNode
must check for the existence ofdashOffset
before creating a uniform node. Otherwise a constant is used.The PR also applies a minor fix to
webgpu_lines_fat_wireframe
which ensures the right dashscale
property name is used.