Skip to content

TSL: Fix debug() changes the compiled code #30944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

TSL: Fix debug() changes the compiled code #30944

merged 3 commits into from
Apr 17, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 17, 2025

Fixes #30926

Description

Fix debug() changes the compiled code.

@sunag sunag added this to the r176 milestone Apr 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.33
78.33		 336.33
78.33		 +0 B
+0 B
WebGPU 544.48
150.86		 544.5
150.86		 +20 B
+3 B
WebGPU Nodes 543.83
150.7		 543.85
150.71		 +20 B
+3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.48
112.23		 465.48
112.23		 +0 B
+0 B
WebGPU 618.14
167.14		 618.16
167.15		 +20 B
+3 B
WebGPU Nodes 573.01
156.49		 573.03
156.5		 +20 B
+3 B

@sunag sunag marked this pull request as ready for review April 17, 2025 02:41
@sunag sunag merged commit bc7aedd into mrdoob:dev Apr 17, 2025
12 checks passed
@sunag sunag deleted the dev-fix-build branch April 17, 2025 02:51
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Fix debug() changes the compiled code (mrdoob#30944)
07648a1 
* fix `build()` return value

* add `webgpu_postprocessing_fxaa` unknown problem

* update description
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Fix debug() changes the compiled code (mrdoob#30944)
64fb356 
* fix `build()` return value

* add `webgpu_postprocessing_fxaa` unknown problem

* update description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r176
Development

Successfully merging this pull request may close these issues.

TSL: Using debug() changes the compiled code
1 participant
@sunag