Skip to content

Conversation

@plietar
Copy link
Member

@plietar plietar commented Nov 8, 2024

No description provided.

@plietar plietar requested a review from richfitz November 8, 2024 11:57
@plietar plietar force-pushed the mrc-5015 branch 3 times, most recently from 5429ddd to bb091ee Compare October 30, 2025 16:13
@plietar plietar changed the base branch from main to fix-ruff October 30, 2025 17:01
@plietar plietar force-pushed the mrc-5015 branch 2 times, most recently from 29fff4d to 4db0e72 Compare October 30, 2025 17:55
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 98.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.19%. Comparing base (919111e) to head (982a9a8).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/pyorderly/outpack/location_push.py 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   99.23%   99.19%   -0.05%     
==========================================
  Files          57       58       +1     
  Lines        4326     4450     +124     
  Branches      285      294       +9     
==========================================
+ Hits         4293     4414     +121     
- Misses         18       20       +2     
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@plietar plietar removed the request for review from richfitz October 31, 2025 12:45
@plietar
Copy link
Member Author

plietar commented Oct 31, 2025

cd example
hatch shell
python3
from pyorderly.run import *
from pyorderly.outpack.location import *
from pyorderly.outpack.location_push import *

outpack_location_add(name="reside-dev", type="packit", args={'url': 'https://reside-dev.packit-dev.dide.ic.ac.uk'})
orderly_run("data")
id = orderly_run("depends")
outpack_location_push(id, "reside-dev")

then if you visit https://reside-dev.packit-dev.dide.ic.ac.uk you should see the two packets (data and depends) that were pushed.

@plietar plietar force-pushed the mrc-5015 branch 2 times, most recently from efb06ee to 0b87139 Compare November 3, 2025 15:52
Base automatically changed from fix-ruff to main November 6, 2025 11:27
Having a method called `list` was causing the builtin list type to be
shadowed, leading to odd error messages. While it is possible to work
around it, renaming the method is the easiest option.
@plietar plietar requested a review from M-Kusumgar November 6, 2025 13:54
Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, got a couple of small comments but nothing major

@plietar plietar merged commit bed0226 into main Nov 14, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants