Correct the path to the file store. #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The R and Rust implementations both use `$ROOT/.outpack/files` as the path to the file store. The Python implementation mistakenly used `$ROOT/files` instead, leading to incompatibilities.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 98.48% 99.12% +0.64%
==========================================
Files 51 51
Lines 4016 4017 +1
Branches 653 371 -282
==========================================
+ Hits 3955 3982 +27
+ Misses 45 21 -24
+ Partials 16 14 -2 ☔ View full report in Codecov by Sentry. |
richfitz
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The R and Rust implementations both use
$ROOT/.outpack/filesas the path to the file store. The Python implementation mistakenly used$ROOT/filesinstead, leading to incompatibilities.