Sort the list of IDs before comparing it. #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
requested review from
richfitz and
weshinsley
and removed request for
weshinsley
The list of packet IDs returned by `unpacked()` is always sorted lexicographically. Some tests were assuming that this was the same as packet creation order, and were comparing the list of packets against another value for equality. However, if the packets were created very closely is time, the timestamp part of their packet ID may be equal, in which case the relative order is determined by the random bytes added to the packets. In that case, lexicographical order may not match packet creation order. This is especially likely on Windows where the timer resolution is quite coarse.
richfitz
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of packet IDs returned by
unpacked()is always sorted lexicographically. Some tests were assuming that this was the same as packet creation order, and were comparing the list of packets against another value for equality.However, if the packets were created very closely is time, the timestamp part of their packet ID may be equal, in which case the relative order is determined by the random bytes added to the packets. In that case, lexicographical order may not match packet creation order. This is especially likely on Windows where the timer resolution is quite coarse.