Bug 1967756 - add [non-prod] to summary string when filing an intermi… #8719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaher
force-pushed
the
nonprod
branch
3 times, most recently
from
9003326 to
6e82bac
Compare
…ttent issue from try.
camd
reviewed
Jul 27, 2025
| this.state = { | ||
| tooltipOpen: {}, | ||
| summary: `Intermittent ${summaryString}`, | ||
| summary: `Intermittent [non-prod] ${summaryString}`, |
There was a problem hiding this comment.
This looks like it would add [non-prod] twice for try. I would suggest:
const summaryPrefix = '';
// extra space intentional in 'try '
const prefix = currentRepo.name === 'try ' ? '[non-prod]' : '';
...
summary: `Intermittent {prefix}${summaryString}`,
| @@ -128,6 +128,9 @@ export class InternalIssueFilerClass extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| if (currentRepo.name === 'try') { | |||
There was a problem hiding this comment.
I might use the similar approach above here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ttent issue from try.