Skip to content

Bug 1967756 - add [non-prod] to summary string when filing an intermi… #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmaher
Copy link
Collaborator

@jmaher jmaher commented May 22, 2025

…ttent issue from try.

@jmaher jmaher self-assigned this May 22, 2025
@jmaher jmaher force-pushed the nonprod branch 3 times, most recently from 9003326 to 6e82bac Compare May 22, 2025 23:40
Copy link
Collaborator

@camd camd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change. I was already partially through this when we chatted over text about doing bot reviews first.

this.state = {
tooltipOpen: {},
summary: `Intermittent ${summaryString}`,
summary: `Intermittent [non-prod] ${summaryString}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it would add [non-prod] twice for try. I would suggest:

const  summaryPrefix = '';
// extra space intentional in 'try '
const prefix = currentRepo.name === 'try ' ? '[non-prod]' : '';
...

summary: `Intermittent {prefix}${summaryString}`,

@@ -128,6 +128,9 @@ export class InternalIssueFilerClass extends React.Component {
}
}

if (currentRepo.name === 'try') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might use the similar approach above here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants