Skip to content

Extract author name from itemprop='name'. #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

Extract author name from itemprop='name'. #943

merged 3 commits into from
Jan 9, 2025

Conversation

danielnixon
Copy link
Contributor

Fixes #935

@danielnixon danielnixon mentioned this pull request Jan 3, 2025
Closed
gijsk
gijsk approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@gijsk gijsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@gijsk gijsk merged commit 706c3d1 into mozilla:main Jan 9, 2025
1 check passed
mislav added a commit to mislav/go-readability that referenced this pull request Jun 23, 2025
@mislav
Improve byline by extracting author name from itemprop=name element
ec33c29 
This ports "Extract author name from itemprop='name'. " (mozilla/readability#943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gijsk gijsk gijsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extracting author from DOM could be more surgical if we detected itemprop="name"
2 participants
@danielnixon @gijsk