Merged
Conversation
k15a
reviewed
Aug 30, 2023
| parent = current.parentNode as SVGElement | ||
| } | ||
| current = svg | ||
| } |
Contributor
There was a problem hiding this comment.
Does it make sense to add else { break } here?
Collaborator
Author
There was a problem hiding this comment.
Yeah agreed, done
k15a
approved these changes
Aug 30, 2023
mergetron
bot
force-pushed
the
fix/svg-scroll
branch
from
f629596 to
6bc5175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures SVG elements can be used as scroll
targets. Currently, they are both not measured correctly but also can lead to an infinite loop, crashing pages.